Skip to content

ref(tanstackstart-react): Use @sentry/conventions#21498

Open
mydea wants to merge 1 commit into
developfrom
feat/use-sentry-conventions-tanstackstart-react
Open

ref(tanstackstart-react): Use @sentry/conventions#21498
mydea wants to merge 1 commit into
developfrom
feat/use-sentry-conventions-tanstackstart-react

Conversation

@mydea

@mydea mydea commented Jun 12, 2026

Copy link
Copy Markdown
Member

Switches @sentry/tanstackstart-react to source span/attribute keys from @sentry/conventions, added as a regular runtime dependency and externalized at build time (resolved at runtime by the consumer's installed copy). No functional change — the attribute values are identical.

Part of splitting the larger @sentry/conventions migration into per-package PRs.

Ref: #20982

@mydea mydea force-pushed the feat/use-sentry-conventions-tanstackstart-react branch from 8bc39c1 to bcbaee6 Compare June 12, 2026 11:24
@mydea mydea changed the base branch from develop to feat/use-sentry-conventions-build-infra June 12, 2026 11:26
@mydea mydea force-pushed the feat/use-sentry-conventions-build-infra branch from 625467a to 2a83a9f Compare June 12, 2026 11:33
@mydea mydea force-pushed the feat/use-sentry-conventions-tanstackstart-react branch from bcbaee6 to 4389650 Compare June 15, 2026 08:11
@mydea mydea changed the base branch from feat/use-sentry-conventions-build-infra to develop June 15, 2026 08:11
@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 27.4 kB - -
@sentry/browser - with treeshaking flags 25.84 kB - -
@sentry/browser (incl. Tracing) 45.7 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 47.94 kB - -
@sentry/browser (incl. Tracing, Profiling) 50.5 kB - -
@sentry/browser (incl. Tracing, Replay) 84.92 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 74.53 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 89.61 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 102.3 kB - -
@sentry/browser (incl. Feedback) 44.56 kB - -
@sentry/browser (incl. sendFeedback) 32.2 kB - -
@sentry/browser (incl. FeedbackAsync) 37.31 kB - -
@sentry/browser (incl. Metrics) 28.47 kB - -
@sentry/browser (incl. Logs) 28.71 kB - -
@sentry/browser (incl. Metrics & Logs) 29.4 kB - -
@sentry/react 29.2 kB - -
@sentry/react (incl. Tracing) 48 kB - -
@sentry/vue 32.42 kB - -
@sentry/vue (incl. Tracing) 47.59 kB - -
@sentry/svelte 27.42 kB - -
CDN Bundle 29.79 kB - -
CDN Bundle (incl. Tracing) 48.2 kB - -
CDN Bundle (incl. Logs, Metrics) 31.33 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 49.49 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 70.62 kB - -
CDN Bundle (incl. Tracing, Replay) 85.52 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 86.77 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 91.37 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 92.62 kB - -
CDN Bundle - uncompressed 88.59 kB - -
CDN Bundle (incl. Tracing) - uncompressed 145.8 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 93.29 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 149.77 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 218.12 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 264.67 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 268.63 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 278.37 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 282.31 kB - -
@sentry/nextjs (client) 50.45 kB - -
@sentry/sveltekit (client) 46.12 kB - -
@sentry/core/server 76.08 kB - -
@sentry/core/browser 63.22 kB - -
@sentry/node-core 61.72 kB -0.01% -1 B 🔽
@sentry/node 128.67 kB +0.01% +1 B 🔺
@sentry/node - without tracing 74.1 kB - -
@sentry/aws-serverless 85.34 kB +0.01% +1 B 🔺
@sentry/cloudflare (withSentry) - minified 174.19 kB - -
@sentry/cloudflare (withSentry) 435.41 kB - -

View base workflow run

@mydea mydea force-pushed the feat/use-sentry-conventions-tanstackstart-react branch 2 times, most recently from 10f8102 to 19eb7a1 Compare June 17, 2026 08:56
Source span/attribute keys from `@sentry/conventions` as a regular dependency
(externalized at build time, resolved at runtime). No functional change.

Maps the `@sentry/conventions/attributes` subpath in the shared TS config for the
repo's `node` moduleResolution type builds.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@mydea mydea force-pushed the feat/use-sentry-conventions-tanstackstart-react branch from 19eb7a1 to 87b30f7 Compare June 17, 2026 09:09
@mydea mydea marked this pull request as ready for review June 17, 2026 09:13
@mydea mydea requested a review from a team as a code owner June 17, 2026 09:13
@mydea mydea requested review from chargome and s1gr1d and removed request for a team June 17, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant